jan at intevation.de
Thu Feb 17 00:28:34 CET 2005
On Mon, Dec 27, 2004 at 03:01:50PM +0100, Jan-Oliver Wagner wrote:
> On Fri, Dec 24, 2004 at 01:56:18AM -0500, Russell Nelson wrote:
> > Hmmmmm. Thuban/Model/map.py says this:
> > def Layers(self):
> > """Return the list of layers contained in the map.
> > The list does not include the label layer"""
> > return self.layers
> > and yet later does this in BoundingBox:
> > for layer in self.layers:
> > if layer is self.label_layer:
> > continue
> > I can't see how both of those can be correct. If the first is wrong,
> > there might be a bug hiding. If the second is wrong, it's just a few
> > wasted cycles.
> I think it is the second.
> Attached is a patch that primarily adds/extends doc strings
> and removes the above mentioned lines as well as adds LabelLayer
> to the TreeInfo output.
> Bernhard Herzog: OK to commit?
> If so, OK to backport to 1_0?
I finally committed since I received no feedback.
Thanks to Russel for pointing this out. Though it was
not a dangerous bug, his comment made me write quite some
doc strings :-)
Jan-Oliver Wagner http://intevation.de/~jan/
Intevation GmbH http://intevation.de/
More information about the Thuban-devel