Fails: TestOGRShapeStore.test_shapes_in_region

[Silke Reimer]

On Wed, Dec 08, 2004 at 06:49:21PM +0100, Martin Schulze wrote:
> Silke Reimer wrote:
> > On Wed, Dec 08, 2004 at 06:15:18PM +0100, Bernhard Reiter wrote:
> > > On Tue, Dec 07, 2004 at 05:44:53PM +0100, cvs at intevation.de wrote:
> > > > Author: nhueffme
> > > > test_OGRShapestore.py 
> > > 
> > > One test fails here.
> > > No further analysis done, maybe this has to do with the version
> > > of pythonogr installed?
> > > I have installed Debian's: python-gdal    1.2.1-1
> > > That is also the freshest that Debian has.  ;)
> > 
> > It seems thate CloseRings is an ogr-method which is available in
> > version 1.2.5 of ogr but not in version 1.2.1. I changed
> > ShapesInRegion slightly so that it does not depend on 'CloseRings'
> > anymore. The tests work now for me. Could you please check it as
> > well?
> 
> Maybe the test (and also the ogr extension code) should rather check
> whether version 1.2.5 of ogr is available?

In my opinion it should rather use only functions from 1.2.1 if
possible. If we really need 1.2.5 at some time we should of course
add this check. In the current case there hasn't been a real need to
use the function 'CloseRings' (it took me just a minute to fix it.)

Greetings,

	Silke

-- 
Intevation GmbH

Georgstrasse 4                    49074 Osnabrück, Germany
http://intevation.de              http://intevation.de/~silke
FreeGIS.org                       http://freegis.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20041209/94086c9e/attachment.bin