Umlauts and Indentation

[Bernhard Reiter]

On Tue, Dec 07, 2004 at 05:44:53PM +0100, cvs at intevation.de wrote:
> Author: nhueffme
> 	test_OGRShapestore.py 

Running the tests with python 2.3, 
I noticed two possible points of improvements:

	The encoding of the python file is not declared,
	the warning has the details:

	/mobilehome/bernhard/hacking/thuban/root/thuban/test/../Extensions/ogr/test/test_OGRShapestore.py:37:
	DeprecationWarning: Non-ASCII character '\xfc' in file
	/mobilehome/bernhard/hacking/thuban/root/thuban/test/../Extensions/ogr/ogrshapes.py
	on line 3, but no encoding declared; see
	http://www.python.org/peps/pep-0263.html for details
	
	This can only be seen with newer python versions.


	Some files use tabs and spaces intermixed.
	In general this calls for trouble, this is why the Thuban
	coding guidelines (in Docs/technotes/ ) have the following:

		Source Formatting
		- Use only spaces for indentation.  Each
		      indentation level is four spaces.

Cheers,
	Bernhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20041209/f306d08e/attachment.bin