frank: thuban/test test_load.py,1.39,1.40

[Bernhard Herzog]

cvs at intevation.de writes:

> Index: test_load.py
> ===================================================================
> RCS file: /thubanrepository/thuban/test/test_load.py,v
> retrieving revision 1.39
> retrieving revision 1.40
> diff -u -d -r1.39 -r1.40
> --- test_load.py	3 Oct 2004 20:49:24 -0000	1.39
> +++ test_load.py	13 Dec 2004 11:52:34 -0000	1.40
[...]
> +    def test_01_single_path_error_fix(self):
> +        """Test single file path error fix."""
> +        # The usual initial case
> +        s_cb = Shapefile_CallBack({
> +                    "search": [("../Data/iceland/roads-line.shp",0)], 
> +                    "check": [(None, None)]})
> +        self.session = load_session(self.filename(), 
> +                                    shapefile_callback =s_cb.s_cb)
> +        self.session.Destroy()
> +        self.session = None

What's this test and the other new tests that never call an assert*
method actually testing?  How do you know the callback was called?  How
do you know the return values of the callback were actually honored?

Also, the self.session.Destroy() call is not necessary.  That's already
taken care of by tearDown.

Finally, there's no need to put numbers into the method names.  The
order in which the tests are executed should not matter at all.

   Bernhard

-- 
Intevation GmbH                                 http://intevation.de/
Skencil                                           http://skencil.org/
Thuban                                  http://thuban.intevation.org/