frank: thuban/test test_load.py,1.41,1.42

[Bernhard Herzog]

cvs at intevation.de writes:

> --- test_load.py	13 Dec 2004 17:51:11 -0000	1.41
> +++ test_load.py	15 Dec 2004 09:44:34 -0000	1.42
[...]
> @@ -1028,15 +1028,34 @@
>  </session>
>  '''
>  
> +    def checkSession(self, session):
> +        """Check if session has been loaded successfully."""
> +        
> +        eq = self.assertEquals
> +
> +        map = session.Maps()[0]
> +        layers = map.Layers()
> +
> +        eq("AltPath Test session", session.Title())
> +        eq("not the iceland map", map.Title())
> +        eq(3,len(layers))
> +        eq("political",layers[0].Title())
> +        eq("roads-line",layers[1].Title())
> +        eq("something else",layers[2].Title())


I'm not sure this really is better than before.  All you check are
titles and the number of layers, but both aspects are not affected by
the filenames.  

Plus, you do this test as the only actual check in three test cases.
That looks fishy to me.  Those three test cases use callbacks that do
differ in what they return.  Doesn't that lead to some observable
differences in behavior that you can test for?

   Bernhard

-- 
Intevation GmbH                                 http://intevation.de/
Skencil                                           http://skencil.org/
Thuban                                  http://thuban.intevation.org/