joey: thuban/Extensions/wms/test test_parser.py,1.3,1.4

[Martin Schulze]

Bernhard Herzog wrote:
> > Modified Files:
> > 	test_parser.py 
> > Log Message:
> > Need to encode non-ascii strings since Python works with unicode
> > strings internally, otherwise comparisons will fail.
> [...]
> > -        self.assertEquals (self.getTitle(),'Frida - Freie Vektor-Geodaten Osnabrück')
> > +        self.assertEquals (self.getTitle().encode('latin-1'),'Frida - Freie Vektor-Geodaten Osnabrück')
> 
> Alternatively you could use unicode literals instead.

That would remove readability for me which is why I opposed against
it.

> BTW, you still have spaces before the opening parenthesis.  Keeping the

I know.  One issue after another.  I believe in clean patches, and
hence, don't want to commit one large patch with everything in it
but smaller ones.

> lines shorter than 79 characters and putting spaces after the commas
> would also be more in line with the coding conventions.

I thought I did?  Hmm, not always, strange.  I'll add that to my list,
also linebreaks.

Regards,

	Joey

-- 
Still can't talk about what I can't talk about.  Sorry.  -- Bruce Schneier