[Thuban-devel] Re: jan: thuban/Thuban/UI baserenderer.py, 1.11, 1.12

[Jan-Oliver Wagner]

On Mon, Oct 04, 2004 at 03:06:41PM +0200, Bernhard Herzog wrote:
> cvs at intevation.de writes:
> 
> > --- baserenderer.py	13 Jul 2004 11:07:45 -0000	1.11
> > +++ baserenderer.py	3 Oct 2004 21:45:48 -0000	1.12
> > @@ -289,7 +289,11 @@
> >                  data = shape.RawData()
> >              else:
> >                  data = shape.Points()
> > -            draw_func(draw_func_param, data, pen, brush)
> > +            if draw_func == self.draw_point_shape:
> 
> This is not the right solution.  There is no guarantee that the
> draw_func used for point shapes is actually self.draw_point_shape.  It's
> not completely wrong to do it this way because it only means that the
> size will be ignored if it's not self.draw_point_shape.
> 
> The best solution I can come with right now is to simply pass the
> classification group to all low-level render functions as well so that
> they can look up additional parameters if they need them.

yes, thats what I thought, but did not dare to do. Again,
with introducing complex symbols, this of course should then
be addressed.

-- 
Jan-Oliver Wagner               http://intevation.de/~jan/

Intevation GmbH                      http://intevation.de/
FreeGIS                                http://freegis.org/