Introduce FileShapeStore
Bernhard Herzog
bh at intevation.de
Mon Apr 25 18:03:00 CEST 2005
Jan-Oliver Wagner <jan at intevation.de> writes:
> On Fri, Apr 22, 2005 at 09:06:21PM +0200, Bernhard Herzog wrote:
>> Jan-Oliver Wagner <jan at intevation.de> writes:
>> > @@ -186,6 +251,10 @@ class ShapefileStore:
>> > """
>> > return ()
>> >
>> > + def Table(self):
>> > + """Return the table containing the attribute data."""
>> > + return self._table
>> > +
>>
>> I think we should avoid moving the methods around unnecessarily, if
>> possible. The same applies to BoundingBox.
>
> do you mean my renaming table to _table and bbox to _bbox?
The patch removes the Table method in one place and adds it in another.
That distracts from the fact that the instance variable is renamed.
Bernhard
--
Intevation GmbH http://intevation.de/
Skencil http://skencil.org/
Thuban http://thuban.intevation.org/
More information about the Thuban-devel
mailing list
This site is hosted by Intevation GmbH (Datenschutzerklärung und Impressum | Privacy Policy and Imprint)