Introduce FileShapeStore

Bernhard Herzog bh at intevation.de
Tue Apr 26 15:49:26 CEST 2005


Jan-Oliver Wagner <jan at intevation.de> writes:

> +class ShapefileStore(FileShapeStore):
>  
[...]
>      def FileType(self):
> -        """Return the filetype. This is always the string 'shapefile'"""
> +        """Return the filetype.
> +
> +        The filetype has to be set in all derived classes.
> +        It must be string.
> +        Known and used types are: "shapefile"
> +        """

Why did you copy the doc-string from the base class where it describes
the abstract purpose of the method to a specific implementation?  Now
the doc-string of the specific implementation doesn't say anything about
that particular implementation anymore.  The original doc-string would
have been just fine, IMO.

   Bernhard

-- 
Intevation GmbH                                 http://intevation.de/
Skencil                                           http://skencil.org/
Thuban                                  http://thuban.intevation.org/




More information about the Thuban-devel mailing list

This site is hosted by Intevation GmbH (Datenschutzerklärung und Impressum | Privacy Policy and Imprint)