bernhard: thuban/test test_stringrepresentation.py,NONE,1.1

[Bernhard Reiter]

Am 18. Oct 2005 um 11:19:32 schrieb Bernhard Herzog:
> cvs at intevation.de writes:
> 
> > class TestInternalEncoding(unittest.TestCase):
> >     """Test around the thuban default encoding."""
> >     def test_notice_bad_internalencoding(self):
> >     	bad_encoding="this-never-is-a-valid-encoding"
> >     	self.assertRaises(LookupError, 
> > 			Thuban.set_internal_encoding,bad_encoding)
> 
> This test sets the default encoding permanently as a side-effect causing
> lots of other tests to fail with an error.  

Ah, good catch.
I somehow believed the tests would have been more seperated.
And my testruns all do fine. I tried again and never saw a failure
like you reported.

I have committed a fix, can you retest?

> Please fix this and write
> tests so that they don't affect other tests.  Typical test failure now
> is:
> 
> ======================================================================
> ERROR: test_load.TestSymbolSize.test
> ----------------------------------------------------------------------
> [...]
> LookupError: unknown encoding: this-never-is-a-valid-encoding
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20051019/84d9308f/attachment.bin