[Thuban-commits] r2698 - in trunk/thuban: . Thuban/Model test

[Bernhard Reiter]

On Monday 18 September 2006 10:59, Bernhard Herzog wrote:
> scm-commit at wald.intevation.org writes:
> > --- trunk/thuban/Thuban/Model/proj.py	2006-09-18 00:45:37 UTC (rev 2697)
> > +++ trunk/thuban/Thuban/Model/proj.py	2006-09-18 00:56:26 UTC (rev 2698)
>
> [...]
>
> >  class Projection(BaseProjection):
> > +    """A proj4 projection object that remembers the parameters.
> >
> > -    """A proj4 projection object that remembers the parameters"""
> > +    Note: it seems that calling
> > +        self.assuregoodlocale()
> > +        self.assureinitlocale()
> > +    before BaseProjection.__init__() is enough to work around the bug.
>
> What bug?  In the context of this doc-string that's not clear.

Text improved.

> Also, I wonder whether assuregoodlocale and assureinitlocale shouldn't
> have a "_"-prefix.

I wondered, too. 
Initially I thought that they had to be called outside of the module
around Foreward() or Inverse() loops, thus I get them public.
As it is only my observation that using it around BaseProjection.__init__() 
is enough, I still kept the names if this observation turns out to be wrong
later.

Bernhard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20060918/cf41ed26/attachment.bin