Spatial selection Tools and Table Enhancements

[Bernhard Reiter]

Hi Barry,

On Sunday 24 September 2006 02:06, Barry Windridge wrote:
> Attached is a zip file containing a number of enhancements to Thuban.
> The enhancements are outlined below (and hopefully reflect changes to
> the head revision on wald).

thanks a lot for your contribution!
This looks like you did a bug chunk of good work!
Of course this also takes a while to review so bear with us here.
I also have to think about how to handle your contribution
in the best way. Two things are on my mind:

a) How to best release it as Free Software.
Ideally we (means Intevation) would be interested
in getting a copyright assignment from you (like with any contributor)
to be able to completely publish Thuban as Free Software and legally 
maintain it. E.g. when we might consider going to GPLV v3 when it comes
out or to LGPL at some point.
Is that something you find worth considering?
Of course we will keep your author name in the files, getting you full credit. 
Currently they do not have a license statement.

b) How to quality control.
In the earlier days we were working much more intensively on Thuban.
During this time we made it a ground rule to have all changes be double 
checked, enhancements thoroughly discussed, tests 
and documentation being written before committing to our repository.

When intensity dropped this turned out to be not feasable, because turnaround 
times were getting quite long. I believe it is more important to take up
good additions and have less quality control, but show some progress even 
when there are bugs to attract more users and developers.

What do you prefer? 
If we try to be stricter, it will prove your code and Thuban in general,
but it also will take a lot longer and might be potentially frustrating for 
you.


> Select by graphics tools that I have previousely posted have been
> fixed to handle multi-part shapes.

Just to be double sure: I understand that this supercedes 
the code you have posted in "Previous/Next Extents Tool" on the 8th,
because it is included in tools2.zip.

> Logic added to make a selection a property of a layer, so that
> multiple layers can have selections simultaneously.

You have added quite a few enhancements on a per layer basis.
What are the use cases that you have in mind for this?
I am wondering if this affect usability of Thuban for users
that could potentially get confused when they have a selection per layer.

As Didrik has pointed out,
to make it easier to test your code, a patch against trunk would be best.
If you work on a checkout of Thuban, svn diff -u will just produce this.
I would also help to have one issue in the patch tracker on wald
per feature, as it enables to discuss and look as one change at a time.

You can also use an svn branch if you like.
Just register on wald, and email me your id so I can upgrade your priviledges.

Best Regards,
Bernhard

-- 
Managing Director - Owner, www.intevation.net       (Free Software Company)
Germany Coordinator, fsfeurope.org       (Non-Profit Org for Free Software)
www.kolab-konsortium.com   (Email/Groupware Solution, Professional Service)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20060927/982c4749/attachment.bin