[Thuban-commits] r2774 - in trunk/thuban: . Thuban/Model Thuban/UI test

[Bernhard Reiter]

Hi Bernhard,

thanks for the comments.
They are both correctly point out weaknesses
in my commits. I have them both on my list as well.

However I have decided to commit a working version first
and do the remaining work later.

On Monday 25 June 2007 12:27, Bernhard Herzog wrote:
> scm-commit at wald.intevation.org writes:

> > -        self.old_state = {}
> > -        self.old_state["mask_type"] = layer.MaskType()
> > +        #self.old_state = {}
> > +        #self.old_state["mask_type"] = layer.MaskType()
>
> [snipped may similar changes]
>
> We do have a version control system, so it's better to simply delete
> code that's not needed anymore.  In the rare cases where it makes sense
> to keep some commented out code in the source file, please add a comment
> why it's there.


> > Modified: trunk/thuban/test/test_load.py

> >      <map title="Test Map">
> >          <rasterlayer visible="false"
> > filename="../../Data/iceland/island.tif" 
> > -                title="My 
> > RasterLayer" opacity="0.4" masktype="alpha"/> 
> > +                title="My 
> > RasterLayer" opacity="0.4"/>
> >      </map>
> >  </session>
> >  '''
>
> AFAICT, this was the only test that tested loading of files with the
> masktype attribute.  Now there is no such test anymore.  

No, but one with opacity.

> Assuming that 
> we want to Thuban to be able to read files that contain the masktype
> attribute we also need tests for it. 

I am still thinking about how to do this best.
It is true there is enough Thuban code around writing this attribute,
so some compatible loader should be in there ignoring the type though.

> The general Thuban policy of how 
> to handle test cases in situations where the file format changes is
> outlined at the beginning of test/test_load.py.

Good hint, thanks.

Bernhard

-- 
Managing Director - Owner: www.intevation.net      (Free Software Company)
Germany Coordinator: fsfeurope.org. Coordinator: www.Kolab-Konsortium.com.
Intevation GmbH, Osnabrück, DE; Amtsgericht Osnabrück, HRB 18998
Geschäftsführer Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20070625/4251f53e/attachment.bin