[Thuban-list] Patch: classifiers

[Daniel Calvelo Aros]

On Thu, 12 Feb 2004 21:50:34 +0100, Jan-Oliver Wagner wrote
> On Thu, Feb 12, 2004 at 09:14:17PM +0100, Bernhard Herzog wrote:
> > First some stylistic things.  To make the code more maintainable in the
> > context of Thuban and to make it easier for us to review the patch,
> > please try to follow the style and practices used in the code already
> > there.  These might also serve as the beginning of a "patch submission
> > guideline".
> 
> I've put your guideline into a web page:
> http://thuban.intevation.org/patch-submission.html

Great! I still have some style points to be enlightened about:

- Use '\' systematically for line breaks?

- Blank lines within code blocks to enhance readability, for code sections,
algorithm phases, etc.?

- Use c_style_caps_as_in_gtk for helper functions but SmalltalkLikeMixedCaps
for classes and class members?

- TODO, FIXME or XXX marks for pending stuff?

- Any guidelines on code comments? One or two ##? doxygen-like openings?

- Adhere to StructuredTextNG in docstrings?

Jan, in the on-line version, there is a weird phrase: " The isn't adhered to
in the code as well as it should. ", and a reference to my HSV patch which
shouldn't be there, IMO. The point Bernhard made about 2.2 compatibility is
VERY important. Please include it.

Do you think this should be in CVS? I'd vote yes, with a reference to it in
the README. HTML? STNG?

> It is not yet linked, but I think it already useful.
> Should we add it to the navigation?
> I vote for putting it right before "CVS".

I'd rather have it between CVS via ssh and Mailing List. Is it time already to
section the menu between users, developers, general info?

Daniel.

-- Daniel Calvelo Aros
-- Dirección General de Información Agraria
-- Ministerio de Agricultura del Perú
-- (51-1)424-9001