popup menu

Jan-Oliver Wagner jan at intevation.de
Sat Apr 17 22:15:34 CEST 2004


On Fri, Apr 16, 2004 at 10:49:51AM +0200, Bernhard Herzog wrote:
> I don't think we should raise a dialog box here.  We don't show one
> either when there's no selection.  We should make sure that the commands
> that call this method are grayed out.  The one in the main window does
> this with the has_selected_shape_layer method.  The context menu should
> do something similar if it doesn't do that yet.

I've greyed out the menu item now.
There is a simple solution to do this directly. I plan
to commit that to the thuban-1-0-branch.

For HEAD, I think it is better to use a Menu like
defined for the main menu.
This has the consequence that I added the Top/Bottom/ToggleVisibility Layer
function to the mainwindow.py module though not actively used there.
The functionality of e.g. raising/lowering layer is now
redundant since it is part of mainwindow as well as part
of of legend (there still used through the toolbar).
So, eventually we should decide whether such functions should
be part of the legend or of the mainwindow.

However, though not the final solution my changes will clean
up stuff a little bit. Will polish my patch and then commit.


What I also recognized is that the toolbar in legend could have
been build the same way the toolbar of the mainwindow is.
But that was a bit more complicated than the menu, so I stopped
this for the moment. First we have to decide whether the actual
functions should be in legend or mainwindow.

	Jan

-- 
Jan-Oliver Wagner               http://intevation.de/~jan/

Intevation GmbH	              	     http://intevation.de/
FreeGIS	                               http://freegis.org/




More information about the Thuban-devel mailing list

This site is hosted by Intevation GmbH (Datenschutzerklärung und Impressum | Privacy Policy and Imprint)