popup menu

[Frank Koormann]

* Jan-Oliver Wagner <jan at intevation.de> [040417 22:15]:
> For HEAD, I think it is better to use a Menu like
> defined for the main menu.
> This has the consequence that I added the Top/Bottom/ToggleVisibility Layer
> function to the mainwindow.py module though not actively used there.
> The functionality of e.g. raising/lowering layer is now
> redundant since it is part of mainwindow as well as part
> of of legend (there still used through the toolbar).
> So, eventually we should decide whether such functions should
> be part of the legend or of the mainwindow.
> 
> However, though not the final solution my changes will clean
> up stuff a little bit. Will polish my patch and then commit.
> 
> What I also recognized is that the toolbar in legend could have
> been build the same way the toolbar of the mainwindow is.
> But that was a bit more complicated than the menu, so I stopped
> this for the moment. First we have to decide whether the actual
> functions should be in legend or mainwindow.

Maybe the best would be to separate the functions currently deeply
sunken in Thuban/UI/mainwindow.py from there and document them. The entire 
concept is not that clear on the first sight, this seems to me being one of 
the reasons why the legend implements it in a different way. 

I can think already of further popup menus (e.g. on the map). Hence for
better transparency based on the separated helpers the menu item 
should be defined where used.

Regards,

        Frank

-- 
Frank Koormann                             <frank.koormann at intevation.de>
 Professional Service around Free Software       (http://intevation.net/)
 FreeGIS Project                                 (http://freegis.org/)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20040418/4397d742/attachment.bin