bernhard: thuban/Extensions/svgexport TODO, 1.3, 1.4 svgmapwriter.py, 1.14, 1.15

Bernhard Herzog bh at intevation.de
Mon Dec 20 13:21:30 CET 2004


cvs at intevation.de writes:

> +For 1.0.1:
> +
> +* Enable label export.
> +* Enable Raster file export.

Do you really meant to get that into 1.0.1?  We're almost done with it.

> --- svgmapwriter.py	19 Dec 2004 10:14:38 -0000	1.14
> +++ svgmapwriter.py	20 Dec 2004 10:08:58 -0000	1.15
> @@ -336,12 +336,13 @@
>      
>      def draw_raster_layer(self, layer):
>          """Draw the raster layer"""
> -        # For now we cannot draw raster layers onto our VirtualDC
> -        pass
> +        # TODO: For now we cannot draw raster layers onto our VirtualDC
> +        log(_("Warning: Raster layer not written as " +
> +              "svgexport does not support this yet!\n"))

There's no need to concatenate the string with a "+" here.  In fact it's
wrong to do that with a translatable string because xgettext will treat
them as two different strings:

#: ../Extensions/svgexport/svgmapwriter.py:340
msgid "Warning: Raster layer not written as "
msgstr ""

#: ../Extensions/svgexport/svgmapwriter.py:341
msgid "svgexport does not support this yet!\n"
msgstr ""


xgettext does know about automatic string concatenation so omitting the +
works fine with xgettext too.


   Bernhard

-- 
Intevation GmbH                                 http://intevation.de/
Skencil                                           http://skencil.org/
Thuban                                  http://thuban.intevation.org/




More information about the Thuban-devel mailing list

This site is hosted by Intevation GmbH (Datenschutzerklärung und Impressum | Privacy Policy and Imprint)