bernhard: thuban/Extensions/svgexport TODO, 1.3, 1.4 svgmapwriter.py, 1.14, 1.15

[Bernhard Reiter]

On Mon, Dec 20, 2004 at 01:21:30PM +0100, Bernhard Herzog wrote:
> cvs at intevation.de writes:
> 
> > +For 1.0.1:
> > +
> > +* Enable label export.
> > +* Enable Raster file export.
> 
> Do you really meant to get that into 1.0.1?  We're almost done with it.

No this is svgexport 1.0.1 not Thuban's version, sorry for the confusion.
> 
> > --- svgmapwriter.py	19 Dec 2004 10:14:38 -0000	1.14
> > +++ svgmapwriter.py	20 Dec 2004 10:08:58 -0000	1.15
> > @@ -336,12 +336,13 @@
> >      
> >      def draw_raster_layer(self, layer):
> >          """Draw the raster layer"""
> > -        # For now we cannot draw raster layers onto our VirtualDC
> > -        pass
> > +        # TODO: For now we cannot draw raster layers onto our VirtualDC
> > +        log(_("Warning: Raster layer not written as " +
> > +              "svgexport does not support this yet!\n"))
> 
> There's no need to concatenate the string with a "+" here.  In fact it's
> wrong to do that with a translatable string because xgettext will treat
> them as two different strings:
> 
> #: ../Extensions/svgexport/svgmapwriter.py:340
> msgid "Warning: Raster layer not written as "
> msgstr ""
> 
> #: ../Extensions/svgexport/svgmapwriter.py:341
> msgid "svgexport does not support this yet!\n"
> msgstr ""
> 
> 
> xgettext does know about automatic string concatenation so omitting the +
> works fine with xgettext too.

Nice, if you feel like, it do the correction.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20041220/7a21dddd/attachment.bin