[Thuban-list] tests for Daniel Cavelo's classifiers

[Moritz Lennert]

[First one didn't come through since I forgot to gzip the patch.]

Finally have come back to this:

On Wed, October 20, 2004 6:53, Jan-Oliver Wagner said:
> On Wed, Oct 20, 2004 at 12:14:43AM +0200, Moritz Lennert wrote:
>> Daniel told me that the lack of test keeps his patches for the classifier
from being integrated into the CVS. Could someone explain to me what
exactly is needed in terms of tests and how I could contribute ?
>
> I tried to apply his patches some time ago but the did not apply cleanly to
current CVS. I was about to analyse what tests are missing.
>
> So first step would be to apply the patch for HEAD.

Attached is a version of the patches that applies cleanly to current (20050118
at ca. 1am) CVS HEAD, plus the necessary additional files that can just be
dropped in. This version of the patch also includes two bug fixes, one to the
discont algorithm and one general one, dealing with no data situations.

>
> Next, one should think about what are the most important tests
> and add them to the directory test/
> There you can see how the other tests are made - not too difficult in
practice but some brain work to have them useful.
> test_color.py is a simple one to get the idea.

I haven't had time to look into this in great detail (and won't have in the
near future), so if someone else has the opportunity to do so, that would be
great. (I guess I'll also have to read
http://diveintopython.org/unit_testing/index.html in order to completely
understand the testing business.)

I would really appreciate if this patch could be integrated into cvs as that
would make it possible to install with debian apt-get and have everything
integrated...

Moritz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: class-custom-xtra-files.tar.gz
Type: application/gzip
Size: 4356 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20050118/7c2cc80c/class-custom-xtra-files.tar.gz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: classification.patch.gz
Type: application/gzip
Size: 11747 bytes
Desc: not available
Url : http://www.intevation.de/pipermail/thuban-devel/attachments/20050118/7c2cc80c/classification.patch.gz