Spatial selection Tools and Table Enhancements

[Bernhard Reiter]

On Sunday 24 September 2006 02:06, Barry Windridge wrote:
> Attached is a zip file containing a number of enhancements to Thuban.
> The enhancements are outlined below (and hopefully reflect changes to
> the head revision on wald).


I took your code for a spin.
Here are my notes how I could make it work (if somebody else want to try it):

20061004
	Trying Barry's tools2.zip contributions.
	Unzip in a directory.
	cp -a trunk/thuban trunk/thuban-barry
	t=trunk/thuban-barry

	cp *.xpm $t/Resources/Bitmaps/
	cp -r BW\ Extensions $t/Extensions/BWExtensions

	# Model
	for f in layer load map save ; do cp $f.py $t/Thuban/Model/ ; done

	# UI
	for f in layerproperties legend mainwindow renderer selection \
 tableview  viewport view ; do cp $f.py $t/Thuban/UI/ ; done 


       # to make it a module
        cp $t/Extensions/__init__.py $t/Extensions/BWExtensions/

 	cat - >>~/.thuban/thubanstart.py << EOF

try:
    import Extensions.BWExtensions.area
    import Extensions.BWExtensions.ruler
    import Extensions.BWExtensions.PrevNextExtent
    import Extensions.BWExtensions.selectByCircle
    import Extensions.BWExtensions.selectByLayer
    import Extensions.BWExtensions.selectByPolygon
    import Extensions.BWExtensions.selectByRectangle
except Exception, x:
    print x
EOF

What I have noticed:
Area tool: When trying to select an area, the canvas goes blank for me,
so I cannot see what I want to select.
Also I cannot end the selection, I needed to click a few times on a different
part to get the map and my control back.



Style:
Using spaces in directory names is suboptimal. This is why I have changed
it to BWExtension. To make it a module an __init__.py was missing.
How did you import all these extensions?

Almost no docstrings.
No tests.


Headers:
Are missing that the files are Free Software.

-- 
Managing Director - Owner, www.intevation.net       (Free Software Company)
Germany Coordinator, fsfeurope.org       (Non-Profit Org for Free Software)
www.kolab-konsortium.com   (Email/Groupware Solution, Professional Service)