raster layer properties and mask patches

[Jonathan Coles]

Am Dienstag, den 25.01.2005, 10:20 +0100 schrieb Jan-Oliver Wagner:
> On Mon, Jan 24, 2005 at 06:04:45PM -0500, Jonathan Coles wrote:
> > this weekends activities have resulted in the following changes:
> 
> wow, this is really cool work!
> 
> > i've attached all the patches. there may seem to be a lot, but they
> > really only cover the above two items.
> 
> the patch for baserenderer.py does not apply cleanly. Can you look
> into this one?

i just did a clean cvs checkout and the patch applied fine. have you
made modifications to your local copy?

> Next there seem to be some commented-out source code lines, probably
> for testing purpose.

there are 3 lines of commented code. i think those should stay, if only
temporarily, because they have to do with playing with how thuban
calculates the region of the raster image to project. other people may
want to experiment with it.

> I started reading the code with color.py and wondered why you have
> introduced the two functions. Shouldn't it be possible to use the hex
> method of Color class?

from my ChangeLog entry:

Although Color.hex() performs the same function, the symmetry with
hex2Color is cleaner. It may also be inappropriate to have a hex()
method.


by inappropriate i mean that the Color object itself shouldn't
(arguably) know how to write the hex string. i remember having a
discussion with bernhard h. about this 2 years ago. we obviously decided
to keep it there. however, like i mention in the log, the symmetry with
hex2Color is nice, and perhaps Color.hex(), if we keep it for backward
compatibility, should use Color2hex to do the conversion.

--jonathan

-- 
=====================================================================
 Jonathan Coles                               http://www.jpcoles.com
 jonathan at jpcoles.com                    GnuPG Key: /gpg_pub_key.asc
=====================================================================