raster layer properties and mask patches

[Jan-Oliver Wagner]

On Tue, Jan 25, 2005 at 07:54:13AM -0500, Jonathan Coles wrote:
> Am Dienstag, den 25.01.2005, 10:20 +0100 schrieb Jan-Oliver Wagner:
> > On Mon, Jan 24, 2005 at 06:04:45PM -0500, Jonathan Coles wrote:
> > > i've attached all the patches. there may seem to be a lot, but they
> > > really only cover the above two items.
> > 
> > the patch for baserenderer.py does not apply cleanly. Can you look
> > into this one?
> 
> i just did a clean cvs checkout and the patch applied fine. have you
> made modifications to your local copy?

$ cd Thuban/UI
$ rm baserenderer.py
$ cvs up
cvs server: Updating .
U baserenderer.py
M classifier.py
M mainwindow.py
$ patch -p2 < /tmp/baserenderer.py.patch
patching file baserenderer.py
Hunk #2 FAILED at 459.
Hunk #3 FAILED at 467.
Hunk #4 FAILED at 484.
3 out of 4 hunks FAILED -- saving rejects to file baserenderer.py.rej

Can you double check you are in sync with CVS?

> > I started reading the code with color.py and wondered why you have
> > introduced the two functions. Shouldn't it be possible to use the hex
> > method of Color class?
> 
> from my ChangeLog entry:
> 
> Although Color.hex() performs the same function, the symmetry with
> hex2Color is cleaner. It may also be inappropriate to have a hex()
> method.
> 
> 
> by inappropriate i mean that the Color object itself shouldn't
> (arguably) know how to write the hex string. i remember having a
> discussion with bernhard h. about this 2 years ago. we obviously decided
> to keep it there. however, like i mention in the log, the symmetry with
> hex2Color is nice, and perhaps Color.hex(), if we keep it for backward
> compatibility, should use Color2hex to do the conversion.

Bernhard Herzog: Is it better to have such functions separate or have
them as methods of corresponding classes?

	Jan
-- 
Jan-Oliver Wagner               http://intevation.de/~jan/

Intevation GmbH                      http://intevation.de/
FreeGIS                                http://freegis.org/